Taken

#0315 Submitted by: displays as whoever is logged in  

I'm using the CVS version from Aug 16.

I have found a strange bug that I only noticed today. The 'submitted by' field of any new issues shows up as being submitted by me....or whoever is currently logged in.

I noticed it when my co-worker submitted an issue. If I am logged in, I see submitted by Greg Baker, however when my co-worker is logged in he sees it as submitted by himself.

There are a few issues that were submitted before I upgraded to the CVS version that this is also happening to. These issues were displaying blank entries for the submitted by field prior to the upgrade.

I'll investigate a little further and hopefully have more info soon. I assume that this error is related to the plone integration.

Submitted by: <Greg Baker>
24-Aug 2006
5 years and 5 months and 2 weeks old
Sections:Core code
Type:bug report
Urgency:normal
Added Issue followup   -   <Greg Baker> permanent link

A quick followup... The email I was sent (as notification) had the correct 'submitted by' information in it.

24-Aug 2006
 
Added Issue followup   -   <Greg Baker> permanent link

Sorry about all the followups in such a short time..

Looking through the ZMI, I found one of the issues that's causing problems and looked at the issue's properties. Under properties, 'fromname' and 'email' are both set correctly. That is, the actual submitter's name and email are correct. Also, the acl_adder value is "/munhousing/acl_users,tony" which appears correct also.

I began to wonder if it was my customized ZPT causing the problem so I renamed it so issuetracker would use the default ZPT and still have the problem. So we can rule that out.

Once again I will investigate further.

24-Aug 2006
 
Added Issue followup   -   <Greg Baker> permanent link

I tracked down this specific error.. Not sure if it is present multiple times in the code or not, but here's the one I found..

in Issue.py, somewhere around line 2779 (may be +/- a few lines since I've edited the file):

authenticated_member = mtool.getAuthenticatedMember()

should be
authenticated_member = mtool.getMemberById(name)

The getAuthenticatedMember method return the currently logged in member, but we want the member who submitted the issue.

Tomorrow I'll poke around the rest of the code to see if this error is in more than one place.

24-Aug 2006
 
Added Issue followup   -   <Greg Baker> permanent link

haha, one more followup, the line number is closer to line 209.. Was looking at the wrong number in vim..

24-Aug 2006
 
Changed status from Open to Taken   -   <Peter Bengtsson> permanent link

Thanks a bunch! I'm away from the office and my laptop for a few days. Will update and fix when I get back.

25-Aug 2006
 
Added Issue followup   -   <Greg Baker> permanent link

The same error is in the getEmail method in Issue.py, directly under the spot mentioned above.

25-Aug 2006
 
Added Issue followup   -   <sse> permanent link

Same problem in Thead.py, line 117

28-Aug 2006
 
Changed status from Taken to Completed   -   <Peter Bengtsson> permanent link

Done. All in svn. Thanks for your support!

29-Aug 2006
 
Added Issue followup   -   <sse> permanent link

I don't understand why, but on line 144 in Thread.py I had to change back to

authenticated_member = mtool.getAuthenticatedMember()

otherwise all emails in the thread were set to the first email address in the thread.

The CVS version has the email correct, the SVN version does not, that is how I came up with this change.

31-Aug 2006
 
Changed status from Completed to Taken   -   <Peter Bengtsson> permanent link

I don't get what you mean. Surely getMemberById(name) returns the member object based on a name and getAuthenticatedMember() just returns the currently logged in member.

There are 4 places where getMemberById() (showing issues and followups) is used and 1 place where getAuthenticatedMember() (submitting issues and followups) is used.

01-Sep 2006
 
 

Name:
Email:
Spambot prevention:number?number?number?number? enter these numbers
(<Greg Baker>, <Peter Bengtsson>, <sse>)more options
Tell a Friend [with more options]

Subscription to changes

 
 

Recent issues